-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the launch_browser fixture behaviour when --browser-channel f… #78
Correct the launch_browser fixture behaviour when --browser-channel f… #78
Conversation
Hey! What was exactly not working? Could you please file first an issue report with a repro? |
Sure, will do right now |
…ehaviour-with-browser-channel' into correct-launch-browser-fixture-behaviour-with-browser-channel
@@ -170,6 +170,12 @@ def launch_browser( | |||
browser_type_launch_args: Dict, | |||
browser_type: BrowserType, | |||
) -> Callable[..., Browser]: | |||
if ( | |||
browser_type.name != "chromium" | |||
and browser_type_launch_args.get("channel") == "chrome" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and browser_type_launch_args.get("channel") == "chrome" |
browser_type.name != "chromium" | ||
and browser_type_launch_args.get("channel") == "chrome" | ||
): | ||
del browser_type_launch_args["channel"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
del browser_type_launch_args["channel"] | |
browser_type_launch_args.pop("channel",None) |
Closing since it seems stale and we recommend to run pytest multiple times with the correct parameters instead of running it a single time and a few parameters won't get passed over. |
…lag is used